Change in ovirt-engine[master]: core: Use allow snapshot when Adding a disk to VM.

mlipchuk at redhat.com mlipchuk at redhat.com
Tue May 15 11:01:11 UTC 2012


Maor Lipchuk has submitted this change and it was merged.

Change subject: core: Use allow snapshot when Adding a disk to VM.
......................................................................


core: Use allow snapshot when Adding a disk to VM.

Next changes in the patch:
1. Set allow_snapshot to a new disk.
2. If the disk which is added is shareable then set the allow_snapshot
attribute accordingly, since shared disk should not used in a snapshot.
3. Move the initialization of disk alias to the execute
4. Cosmetic changes.
5. Use default null for Guid vmSnapshotId instead of empty Guid.

Signed-off-by: Maor Lipchuk <mlipchuk at redhat.com>
Change-Id: I135669c5f7bfb85fda561a47258834cd35d7688b
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddImageFromScratchCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddDiskParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImagesActionsParametersBase.java
4 files changed, 29 insertions(+), 5 deletions(-)

Approvals:
  Maor Lipchuk: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/4231
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I135669c5f7bfb85fda561a47258834cd35d7688b
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>



More information about the Engine-commits mailing list