Change in ovirt-engine[master]: webadmin: Edit Pool shows different template (#820231)

vszocs at redhat.com vszocs at redhat.com
Wed May 16 13:07:54 UTC 2012


Vojtech Szocs has submitted this change and it was merged.

Change subject: webadmin: Edit Pool shows different template (#820231)
......................................................................


webadmin: Edit Pool shows different template (#820231)

https://bugzilla.redhat.com/820231

When creating a pool from a template, than edit pool
shows a different template than the one from which it has been
created.

The problem was, that the edit pool dialog used the same behavior
class for both edit and new pool (the NewPoolModelBehavior),
and this one selects always the first pool.

The fix was to create a separate class ExistingPoolModelBehavior
which initializes the template correctly.

Change-Id: Iea1270499ebd3b1c6f7ee93d62cbc7a8167fb7c1
Signed-off-by: Tomas Jelinek <tjelinek at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingPoolModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewPoolModelBehavior.java
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/PoolModelBehaviorBase.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java
6 files changed, 388 insertions(+), 375 deletions(-)

Approvals:
  Vojtech Szocs: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/4423
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iea1270499ebd3b1c6f7ee93d62cbc7a8167fb7c1
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>



More information about the Engine-commits mailing list