Change in ovirt-engine[master]: core: fix pass bridged and mtu property in add/edit network ...

rgolan at redhat.com rgolan at redhat.com
Mon May 21 08:15:24 UTC 2012


Roy Golan has submitted this change and it was merged.

Change subject: core: fix pass bridged and mtu property in add/edit network api
......................................................................


core: fix pass bridged and mtu property in add/edit network api

passing the "bridged" and "mtu" parameter according to the logical network property
both where included in setupnetworks command but missing in add/edit network flow (AKA old API)

* refactor the parameter class to hold the network entity from the DB.
* pass bridged=true|false according to the network.isVmNetwork() value.
* pass mtu value in case the logical network mtu is not 0 (which means don't override)

Change-Id: Ifacdace1f1517df13d087ed6102cd30496c45855
Signed-off-by: Roy Golan <rgolan at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachNetworkToVdsInterfaceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateNetworkToVdsInterfaceCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/NetworkVdsmVDSCommandParameters.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/AddNetworkVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/EditNetworkVDSCommand.java
6 files changed, 176 insertions(+), 66 deletions(-)

Approvals:
  Roy Golan: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/4198
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifacdace1f1517df13d087ed6102cd30496c45855
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>



More information about the Engine-commits mailing list