Change in ovirt-engine[master]: core: Cleanup SetupNetworksHelper part 4

masayag at redhat.com masayag at redhat.com
Mon May 21 09:34:15 UTC 2012


Moti Asayag has submitted this change and it was merged.

Change subject: core: Cleanup SetupNetworksHelper part 4
......................................................................


core: Cleanup SetupNetworksHelper part 4

1. Added some blank lines to separate bulks of code.
2. Reduced visibility of methods as possible.
3. Removed some double ifs.
4. Added doc of return value to validate() method.

Change-Id: Id36c8e3a25530c134b0a279692814f5efa54a3ed
Signed-off-by: Mike Kolesnik <mkolesni at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetupNetworksHelper.java
1 file changed, 26 insertions(+), 22 deletions(-)

Approvals:
  Moti Asayag: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/4600
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id36c8e3a25530c134b0a279692814f5efa54a3ed
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>



More information about the Engine-commits mailing list