Change in ovirt-engine[master]: engine, webadmin: Read ApplicationMode upon WebAdmin startup

vszocs at redhat.com vszocs at redhat.com
Mon May 21 15:12:55 UTC 2012


Vojtech Szocs has submitted this change and it was merged.

Change subject: engine,webadmin: Read ApplicationMode upon WebAdmin startup
......................................................................


engine,webadmin: Read ApplicationMode upon WebAdmin startup

This patch allows WebAdmin application to read ApplicationMode
config property right upon its startup.

Changes in 'engine' component:

1. Added ConfigurationValues.ApplicationMode as allowed config value
   when invoking GetConfigurationValue via Backend.RunPublicQuery
   (this is needed in order to read ApplicationMode for all users)

Changes in 'webadmin' component:

2. GwtDynamicHostPageServlet refactored a bit:
   - introduced writeJsObject() method
   - createQueryParams() method changed to initQueryParams()
   - removed filterQueries() method, its effect is now achieved
     by overriding initQueryParams() in UserportalDynamicHostingServlet
   - added convenience runQuery() and runPublicQuery() methods

3. WebadminDynamicHostingServlet now includes 'applicationMode'
   JavaScript data object into the host page, with its value being
   read via GetConfigurationValue/ApplicationMode as public query

4. Created package 'org.ovirt.engine.ui.webadmin.uimode':
   - UiModeData is the overlay type for 'applicationMode' JS object
   - UiMode enum represents possible 'applicationMode' values

5. Reading ApplicationMode in WebAdmin ApplicationInit via
   handleUiMode() method

Change-Id: I03ab99f18d1bbcba57385bf1a29d32b15050b7bf
Signed-off-by: Vojtech Szocs <vszocs at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GwtDynamicHostPageServlet.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/UserportalDynamicHostingServlet.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/WebadminDynamicHostingServlet.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/system/ApplicationInit.java
A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uimode/UiMode.java
A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uimode/UiModeData.java
7 files changed, 176 insertions(+), 22 deletions(-)

Approvals:
  Vojtech Szocs: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/4433
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I03ab99f18d1bbcba57385bf1a29d32b15050b7bf
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa at redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>



More information about the Engine-commits mailing list