Change in ovirt-engine[master]: core: Cleanup Permissions Commands

ofrenkel at redhat.com ofrenkel at redhat.com
Tue May 22 08:43:07 UTC 2012


Omer Frenkel has submitted this change and it was merged.

Change subject: core: Cleanup Permissions Commands
......................................................................


core: Cleanup Permissions Commands

1. Replaced DbFacade.getInstance().getXXDAO() with getXXDAO()
2. Added serialVersionUID
3. Solved warnings detected by Eclipse IDE.

Change-Id: I4a4415ab37fd1b38aa8065c7a54f21459562f30d
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddPermissionCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddSelfPermissionCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddSystemPermissionCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/PermissionsCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemovePermissionCommand.java
5 files changed, 30 insertions(+), 27 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, but someone else must approve
  Omer Frenkel: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/4483
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4a4415ab37fd1b38aa8065c7a54f21459562f30d
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list