Change in ovirt-engine[master]: core:Update VmDao to return multiple Vms for disk.

mlipchuk at redhat.com mlipchuk at redhat.com
Thu May 24 08:14:33 UTC 2012


Maor Lipchuk has submitted this change and it was merged.

Change subject: core:Update VmDao to return multiple Vms for disk.
......................................................................


core:Update VmDao to return multiple Vms for disk.

Changed the API of the VMDao to return list of VMs.
Also since now disk can be on multiple Vms, the validation if disk is part of
VM should reference a list of VMs.

Signed-off-by: Maor Lipchuk <mlipchuk at redhat.com>
Change-Id: Ib8d0bbef4828100217e488d6dbab1b81ee65103d
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateSnapshotCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/HotUnPlugDiskFromVmCommandTest.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDAOTest.java
7 files changed, 72 insertions(+), 10 deletions(-)

Approvals:
  Maor Lipchuk: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/4491
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib8d0bbef4828100217e488d6dbab1b81ee65103d
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>



More information about the Engine-commits mailing list