Change in ovirt-engine[master]: core: UnPowerMock FenceVdsBaseCommandTest

lhornyak at redhat.com lhornyak at redhat.com
Fri May 25 10:00:22 UTC 2012


Laszlo Hornyak has submitted this change and it was merged.

Change subject: core: UnPowerMock FenceVdsBaseCommandTest
......................................................................


core: UnPowerMock FenceVdsBaseCommandTest

Removed PowerMock dependency from FenceVdsBaseCommandTest and replaced
it with an annonymous inheriting class that returns the needed DAOs.

Some cleanup in FenceVdsBaseCommand was required in order to allow this
technique to work.

Change-Id: I32b2c732e9ec63641e8b442ff5f86892e2689c4d
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/FenceVdsBaseCommandTest.java
2 files changed, 29 insertions(+), 37 deletions(-)

Approvals:
  Laszlo Hornyak: Verified; Looks good to me, approved
  Allon Mureinik: Verified


--
To view, visit http://gerrit.ovirt.org/4685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I32b2c732e9ec63641e8b442ff5f86892e2689c4d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak at redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list