Change in ovirt-engine[master]: core: UnPowerMock DeactivateStorageDomainCommandTest

lhornyak at redhat.com lhornyak at redhat.com
Fri May 25 10:43:44 UTC 2012


Laszlo Hornyak has submitted this change and it was merged.

Change subject: core: UnPowerMock DeactivateStorageDomainCommandTest
......................................................................


core: UnPowerMock DeactivateStorageDomainCommandTest

Removed PowerMock dependency from DeactivateStorageDomainCommandTest,
and replaced it with spying the command directly.

In order to facilitate the change, ExecuteTransactionAnswer was
extracted from AttachStorageDomainToPoolCommandTest and turned into a
top-level class.

Change-Id: Ifc9c0882e76c17232e285be59a5ffb16b9128fc8
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ExecuteTransactionAnswer.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommandTest.java
3 files changed, 62 insertions(+), 65 deletions(-)

Approvals:
  Laszlo Hornyak: Verified; Looks good to me, approved
  Allon Mureinik: Verified


--
To view, visit http://gerrit.ovirt.org/4767
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifc9c0882e76c17232e285be59a5ffb16b9128fc8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak at redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list