Change in ovirt-engine[master]: core: UnPowerMock GetLunsByVgIdTest

lhornyak at redhat.com lhornyak at redhat.com
Fri May 25 12:12:53 UTC 2012


Laszlo Hornyak has submitted this change and it was merged.

Change subject: core: UnPowerMock GetLunsByVgIdTest
......................................................................


core: UnPowerMock GetLunsByVgIdTest

Removed PowerMock depedency from GetLunsByVgIdTest and replaced it with
spying the DAOs.

In order to achieve this a minor refactoring was required in
GetLunsByVgIdQuery, making it use the standard getDbFacade() instead of
implementing its own getDb().

Change-Id: I7a742edf5f06bb19ddf87947a437ec2763eb257a
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetLunsByVgIdQuery.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetLunsByVgIdTest.java
2 files changed, 30 insertions(+), 31 deletions(-)

Approvals:
  Laszlo Hornyak: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/4775
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7a742edf5f06bb19ddf87947a437ec2763eb257a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak at redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list