Change in ovirt-engine[master]: core: Change validation to return empty list

mkolesni at redhat.com mkolesni at redhat.com
Mon May 28 07:46:25 UTC 2012


Mike Kolesnik has submitted this change and it was merged.

Change subject: core: Change validation to return empty list
......................................................................


core: Change validation to return empty list

Validation of parameters would return null if no violation occurred,
but this is problematic when coming to test that a certain violation
occurred, so changing to return empty list in case of no violations.

Change-Id: Iabf5c3d6b151284dd3c03fed377950a3f559547f
Signed-off-by: Mike Kolesnik <mkolesni at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/ExecutionHandler.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/ValidationUtils.java
3 files changed, 7 insertions(+), 3 deletions(-)

Approvals:
  Mike Kolesnik: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/4373
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iabf5c3d6b151284dd3c03fed377950a3f559547f
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list