Change in ovirt-engine[master]: core: fix jobProperties for delete vm and template from expo...

ofrenkel at redhat.com ofrenkel at redhat.com
Tue May 29 13:16:21 UTC 2012


Omer Frenkel has submitted this change and it was merged.

Change subject: core: fix jobProperties for delete vm and template from export (#818111)
......................................................................


core: fix jobProperties for delete vm and template from export (#818111)

https://bugzilla.redhat.com/show_bug.cgi?id=818111

when removing vm/template from export domain,
the job properties tried to use entities from db,
which are not always available, and not correct to use.

this fix implement override for getVm() and getVmTemplate() to get from export domain,
and use it.
most of the code was just moved from canDoAction

also set the domain name which was not set,
and fixed in ExecutionMessages.properties to the right var name

Change-Id: I936501874e9a29b18bdddf1b65e7150e88cfe475
Signed-off-by: Omer Frenkel <ofrenkel at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmFromImportExportCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateFromImportExportCommand.java
M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties
3 files changed, 102 insertions(+), 39 deletions(-)

Approvals:
  Omer Frenkel: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/4714
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I936501874e9a29b18bdddf1b65e7150e88cfe475
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list