Change in ovirt-engine[master]: core: Fix hierarchy of Bond Parameters classes

masayag at redhat.com masayag at redhat.com
Wed May 30 13:21:38 UTC 2012


Moti Asayag has submitted this change and it was merged.

Change subject: core: Fix hierarchy of Bond Parameters classes
......................................................................


core: Fix hierarchy of Bond Parameters classes

The patch extracts a base class for Bond Parameters classes.
It also contains adjustment of naming to Java standards and organizes
classes accordingly.

In addition, the vlanTag attribute was deleted from AddBondParameters
since it isn't being in used and it is a duplication of the vlanId
attribute.

Change-Id: I04fdfa603cd6710f7966b9df69858b5db727547f
Signed-off-by: Moti Asayag <masayag at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsBondCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddBondParameters.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/BondParametersBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveBondParameters.java
4 files changed, 115 insertions(+), 111 deletions(-)

Approvals:
  Moti Asayag: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/4863
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I04fdfa603cd6710f7966b9df69858b5db727547f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>



More information about the Engine-commits mailing list