Change in ovirt-engine[master]: engine: cannot unpause VM started in paused mode

[rgolan at redhat.com]

Roy Golan has submitted this change and it was merged.

Change subject: engine: cannot unpause VM started in paused mode
......................................................................


engine: cannot unpause VM started in paused mode

Have 2 clusters, in each have one host. In one of
this clusters create a VM. Run it in pause mode,
wait until it starts in the pause mode and tham start it.

The VM will not start.

The problem was in VdsSelector in the check where it
tried to find out, if the specific VM is migrating to
the same host.

This check makes sense for the migrating of the VM,
but not for running it.

Fixed by making the checks aware of if the VM is
migrating or not.

This patch also removes one duplication - one of the
checks has been copy-pasted twice.

There was also a workaround which ignored the situation
that the VM would be migrated to the same host - it is
already implmented in the HostValidator so removed.

Change-Id: I8cca521f79bfb7d5762f2c996200916a10afc36a
Bug-Url: https://bugzilla.redhat.com/872205
Signed-off-by: Tomas Jelinek <tjelinek at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/PowerClientMigrateOnConnectCheckCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsSelector.java
4 files changed, 28 insertions(+), 49 deletions(-)

Approvals:
  Roy Golan: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/8994
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8cca521f79bfb7d5762f2c996200916a10afc36a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>