Change in ovirt-engine[master]: core: Removing reschedule of monitoring of vdsm by another v...

mkublin at redhat.com mkublin at redhat.com
Mon Nov 5 09:52:18 UTC 2012


Michael Kublin has submitted this change and it was merged.

Change subject: core: Removing reschedule of monitoring of vdsm by another vdsm
......................................................................


core: Removing reschedule of monitoring of vdsm by another vdsm

The following patch will remove a reschedule of monitoring of vdsm, from
other thread of monitoring.
Such behaviour can cause to spending all quartz thread on reschedule of monitoring of the
same vdsm.
The use case:
1. We have 10 vdsms and 10 vms that are migrating to same vdsm
2. Each vdsm can schedule additional refresh of destination vdsm
3. Result : we has 10 quartz jobs that are trying to monitor the same vdsm and additional job
   which is regular monitoring (runs each 2 seconds)
It is obvious that under load and in more big environment we will have a timeouts when all
quartz threads will be busy by monitoring of the same vdsms

Change-Id: I5534b3b627e992efbce152935ad207c978a7feed
Signed-off-by: Michael Kublin <mkublin at redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
2 files changed, 4 insertions(+), 37 deletions(-)

Approvals:
  Michael Kublin: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/8483
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5534b3b627e992efbce152935ad207c978a7feed
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkublin at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list