Change in ovirt-engine[master]: engine: re-run mechanism improvements

[ofrenkel at redhat.com]

Omer Frenkel has submitted this change and it was merged.

Change subject: engine: re-run mechanism improvements
......................................................................


engine: re-run mechanism improvements

- RunVmCommandBase#rerun method no longer invokes rerunInternal
method within a different thread because there is no need for a
different thread when it is called from the command itself. the
code of rerunInternal method was moved to rerun method without
creating a new thread to run it instead.
when rerun method is invoked by VdsEventListener, its code should
still run in a different thread so it is called from a new thread
in VdsEventListener#rerun method.

- adjust the rerun mechanism such that the logs & events would
reflect the process better:
* on re-run, log the results of the previous run before checking
whether the maximum rerun attempts were exceeded, so that it would
be logged every time.
* add a missing log call after exceeding the maximum re-run attempts
to log a message that indicates the command failed.
* make sure that when a command that is being rerun is failed due to
can-do-action check, the failure event will appear only once.

Change-Id: I557636a94d74772635102c6a33dc923d91332a3e
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmToServerCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java
4 files changed, 30 insertions(+), 23 deletions(-)

Approvals:
  Omer Frenkel: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/9184
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I557636a94d74772635102c6a33dc923d91332a3e
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>