Change in ovirt-engine[master]: engine: Fail Import Vm on MAC Address (#872100)

msalem at redhat.com msalem at redhat.com
Sun Nov 18 08:05:45 UTC 2012


Muli Salem has submitted this change and it was merged.

Change subject: engine: Fail Import Vm on MAC Address (#872100)
......................................................................


engine: Fail Import Vm on MAC Address (#872100)

This patch changes the VmInterfaceManager to throw
a VdcBllExpection when trying to add a interface with
a used MAC address.

It also adds a new VdcBllError for this case, and changes
the VmInterfaceManagerTest according to the change in
behavior.

Change-Id: I68d37ed183adb4adf8abf8b11332f6c822f8c4c0
Bug-Url: https://bugzilla.redhat.com/872100
Signed-off-by: Muli Salem <msalem at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/VmInterfaceManager.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/VmInterfaceManagerTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
M backend/manager/modules/utils/src/test/resources/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
11 files changed, 74 insertions(+), 69 deletions(-)

Approvals:
  Muli Salem: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/9144
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I68d37ed183adb4adf8abf8b11332f6c822f8c4c0
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <msalem at redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Muli Salem <msalem at redhat.com>



More information about the Engine-commits mailing list