Change in ovirt-engine[master]: core: Quota refactor

gchaplik at redhat.com gchaplik at redhat.com
Mon Nov 19 13:07:53 UTC 2012


Gilad Chaplik has submitted this change and it was merged.

Change subject: core: Quota refactor
......................................................................


core: Quota refactor

Design can be found here:
http://wiki.ovirt.org/wiki/Features/Design/Quota-3.2

Adding Objects for Quota consumption parameters
Adding InvalidQuotaParametersException
Unit test of QuotaManager redesign to fit the new API
Change of AddDiskCommand to new design
Change implementation of AddVmCommand.
Change implementation of AddVmTemplateCommand.
Change implementation for ChangeQuotaCommand
Change implementation for CommonVmPoolWithVmsCommand
Change implementation for ChangeQuotaForDiskCommand
Changed implementation of CreateAllSnapshotsFromVmCommand
Changed implementation of AddVmTemplateCommand
Changed implementation of ImportVmCommand
Changed implementation of MoveOrCopyDiskCommand
Changed implementation of RemoveDiskCommand
QuotaCRUDCommand no longer implements Quotable.
Change implementation of RemoveVmCommand
Change implementation of RemoveVmFromImportExportCommand
Change implementation of RemoveVmTemplateCommand
Change implementation of RemoveVmTemplateFromImportExportCommand
Change implementation of RestoreAllSnapshotsCommand
Change implementation of RunVmCommand
Change implementation of RunVmOnceCommand
Change implementation of StopVmCommandBase
Change implementation of UpdateVmCommand
Change implementation of UpdateVmDiskCommand

Cleaned unused methods from QuotaManager
activate new design in CommandBase (removed all records of old design)

Change-Id: I109ae8ae0191f46abaa1be21a7ecfebe50b9993f
Signed-off-by: Ofri Masad <omasad at redhat.com>
---
M backend/manager/dbscripts/create_functions.sql
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeQuotaForDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QuotaCRUDCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmFromImportExportCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateFromImportExportCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/ChangeQuotaCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/InvalidQuotaParametersException.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaConsumptionParameter.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaConsumptionParametersWrapper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManagerAuditLogger.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaSanityParameter.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaStorageConsumptionParameter.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaStorageDependent.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaVdsDependent.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaVdsGroupConsumptionParameter.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/quota/QuotaManagerTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/quota/QuotaPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/quota/SubTabQuotaStorageView.java
41 files changed, 1,759 insertions(+), 1,683 deletions(-)

Approvals:
  Gilad Chaplik: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/9180
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I109ae8ae0191f46abaa1be21a7ecfebe50b9993f
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <omasad at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: ofri masad <omasad at redhat.com>



More information about the Engine-commits mailing list