Change in ovirt-engine[master]: engine: Extract Vlan Id Validation (#871864)

msalem at redhat.com msalem at redhat.com
Thu Nov 22 09:28:13 UTC 2012


Muli Salem has submitted this change and it was merged.

Change subject: engine: Extract Vlan Id Validation (#871864)
......................................................................


engine: Extract Vlan Id Validation (#871864)

This patch extracts repetitive code to the mutual parent
class of AddNetworkCommand and UpdateNetworkCommand.

Change-Id: Ifc54da41602245101d97f7afce86d5b97e6cfa36
Bug-Url: https://bugzilla.redhat.com/871864
Signed-off-by: Muli Salem <msalem at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddNetworkCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/NetworkCommon.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateNetworkCommand.java
3 files changed, 39 insertions(+), 45 deletions(-)

Approvals:
  Muli Salem: Verified; Looks good to me, approved
  Moti Asayag: Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/9312
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifc54da41602245101d97f7afce86d5b97e6cfa36
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <msalem at redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Muli Salem <msalem at redhat.com>



More information about the Engine-commits mailing list