Change in ovirt-engine[master]: core: Fix NPE on Clone VM from Snapshot

mlipchuk at redhat.com mlipchuk at redhat.com
Sun Nov 25 16:14:20 UTC 2012


Maor Lipchuk has submitted this change and it was merged.

Change subject: core: Fix NPE on Clone VM from Snapshot
......................................................................


core: Fix NPE on Clone VM from Snapshot

Clone VM from snapshot throw NPE while using MoveOrCopyImageGroup.
This happens since AddVmFromSnapshot creates the task first with the
parameters and only after that it creates the disk in the DB.
The proposed fix is to get the wipeAfterDelete flag from the parameters
in case the destination disk is null.
This fix should be revisited, to change the AddVmFromSnapshot to create
the disk before the creation of task.

Change-Id: I2c18b1ac552f598fc20e74aa67f81dabb915a8c2
Signed-Off-By: Maor Lipchuk <mlipchuk at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyImageGroupCommand.java
1 file changed, 7 insertions(+), 3 deletions(-)

Approvals:
  Maor Lipchuk: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/9445
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2c18b1ac552f598fc20e74aa67f81dabb915a8c2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: ofri masad <omasad at redhat.com>



More information about the Engine-commits mailing list