Change in ovirt-engine[master]: core: several multiple RemoveVmCommand get java.lang.Runtime...

mkublin at redhat.com mkublin at redhat.com
Tue Oct 2 09:29:30 UTC 2012


Michael Kublin has submitted this change and it was merged.

Change subject: core: several multiple RemoveVmCommand get java.lang.RuntimeException when restarting engine
......................................................................


core: several multiple RemoveVmCommand get java.lang.RuntimeException when restarting engine

The bug was caused because of unneeded update at CommandBase of parameters of async tasks,
during update were passed parameters of parent command,
the update is unneeded because of parameters are passed during creation of task,
because of update was done partitial we got java.lang.RuntimeException.
Solution: to remove unneded update, also we will have additional benefit:
reduced at least two updates query on every task

Change-Id: Ie885b5d069abf0592454f6834466d3fcb5a47c85
Bug-Url: https://bugzilla.redhat.com/861154
Signed-off-by: Michael Kublin <mkublin at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java
2 files changed, 6 insertions(+), 8 deletions(-)

Approvals:
  Michael Kublin: Verified
  Yair Zaslavsky: Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/8291
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie885b5d069abf0592454f6834466d3fcb5a47c85
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkublin at redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list