Change in ovirt-engine[master]: core: Fix task parame creation regression (862799)

derez at redhat.com derez at redhat.com
Wed Oct 3 15:20:38 UTC 2012


Daniel Erez has submitted this change and it was merged.

Change subject: core: Fix task parame creation regression (862799)
......................................................................


core: Fix task parame creation regression (862799)

A careless refactoring introduced a regression that disallowed creating
tasks for external commands.

This patch fixes it, and restores the previous behaviour (albeit in a
streamlined, readable, manner, that does not involve copy-pasting the
same block of code over and over).

Change-Id: I71290e58978b680dbbbf88b024a19482b637a91b
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=862799
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
1 file changed, 3 insertions(+), 7 deletions(-)

Approvals:
  Daniel Erez: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/8339
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I71290e58978b680dbbbf88b024a19482b637a91b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Asaf Shakarchi <asaf at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>



More information about the Engine-commits mailing list