Change in ovirt-engine[master]: core: Improving RegisterVdsQuery

mkublin at redhat.com mkublin at redhat.com
Tue Oct 9 09:44:58 UTC 2012


Michael Kublin has submitted this change and it was merged.

Change subject: core: Improving RegisterVdsQuery
......................................................................


core: Improving RegisterVdsQuery

The following patch is clean up and improving of RegisterVdsQuery.
The patch doesn't contains all improvements, these is only a first step
Current improvements:
1. Removed unneeded opening of threads - we opened a thread but still wait until
   it will finished, no reason for that
2. Removed unneeded global transaction - never good
3. Some small code clean ups

Change-Id: Ida0d776fa5d24a2b68c774a82d5cda0b67c70f44
Signed-off-by: Michael Kublin <mkublin at redhat.com>
---
M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
3 files changed, 116 insertions(+), 246 deletions(-)

Approvals:
  Michael Kublin: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/8419
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ida0d776fa5d24a2b68c774a82d5cda0b67c70f44
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkublin at redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list