Change in ovirt-engine[master]: core: WipeAfterDelete defaults to true in GUI, but false in ...

Gerrit Code Review gerrit2 at gerrit.ovirt.org
Thu Oct 18 16:50:34 UTC 2012


Anonymous Coward has submitted this change and it was merged.

Change subject: core: WipeAfterDelete defaults to true in GUI, but false in REST API (#845466)
......................................................................


core: WipeAfterDelete defaults to true in GUI, but false in REST API (#845466)

WipeAfterDelete in gui default to false for File Storage Domains and
for Block storage domains the value is defined by SANWipeAfterDelete
configuration value.

The backend logic has been changed to mimic this behaviour.

Change-Id: I8cb77b017282733d72ff66af499b576674674e01
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=845466
Signed-off-by: Ravi Nori <rnori at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/WipeAfterDeleteUtils.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/BaseDisk.java
3 files changed, 34 insertions(+), 4 deletions(-)

Approvals:
  Michael Pasternak: Looks good to me, approved

Objections:
  Omer Frenkel: Do not submit


--
To view, visit http://gerrit.ovirt.org/8628
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8cb77b017282733d72ff66af499b576674674e01
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori at redhat.com>



More information about the Engine-commits mailing list