Change in ovirt-engine[master]: core: NPE while adding lun disks (#869596)

derez at redhat.com derez at redhat.com
Sun Oct 28 10:26:40 UTC 2012


Daniel Erez has submitted this change and it was merged.

Change subject: core: NPE while adding lun disks (#869596)
......................................................................


core: NPE while adding lun disks (#869596)

fixing regression that was introduced in patch with
change id I8cb77b017282733d72ff66af499b576674674e01

while adding a disk there is an attempt to check the storage domain
of the disk in order to verify whether the added disk storage needs to be
wiped after it's deletion, lun disks don't have storage domain and can't be
wiped which caused to NPE.

Change-Id: Id754bdd7b49ff0dcc80b060f5900f8e3ea313637
Bug-Url: https://bugzilla.redhat.com/869596
Signed-off-by: Liron Aravot <laravot at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
1 file changed, 4 insertions(+), 5 deletions(-)

Approvals:
  Daniel Erez: Looks good to me, approved
  Allon Mureinik: Looks good to me, but someone else must approve
  Vered Volansky: Looks good to me, but someone else must approve
  Liron Aravot: Verified


--
To view, visit http://gerrit.ovirt.org/8821
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id754bdd7b49ff0dcc80b060f5900f8e3ea313637
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmishra at linux.vnet.ibm.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>



More information about the Engine-commits mailing list