Change in ovirt-engine[master]: webadmin: Add checkbox to override NFS mount options

mlipchuk at redhat.com mlipchuk at redhat.com
Wed Oct 31 12:56:45 UTC 2012


Maor Lipchuk has submitted this change and it was merged.

Change subject: webadmin: Add checkbox to override NFS mount options
......................................................................


webadmin: Add checkbox to override NFS mount options

With the change to make nfs v3 the default, mounting any nfs domain with
compatibility version 3.1+ will result in the engine sending a mount
version to vdsm.

This provides a way to specify that no options should be specified,
which results in the values being null in the db and not sent to vdsm
when connecting the storage.  This allows vdsm.conf's nfs_mount_options
to be processed properly as well (see bug 826921 for details).

Bug-Url: https://bugzilla.redhat.com/871534
Change-Id: If01d7fefc392fd296838df5da9faa9b4157327cf
Signed-off-by: Greg Padgett <gpadgett at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NfsStorageModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/NfsStorageView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/NfsStorageView.ui.xml
5 files changed, 88 insertions(+), 19 deletions(-)

Approvals:
  Maor Lipchuk: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/8798
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If01d7fefc392fd296838df5da9faa9b4157327cf
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>



More information about the Engine-commits mailing list