Change in ovirt-engine[master]: engine: Prevent move to empty quota (#845070)

dfediuck at redhat.com dfediuck at redhat.com
Wed Sep 5 15:03:55 UTC 2012


Doron Fediuck has submitted this change and it was merged.

Change subject: engine: Prevent move to empty quota (#845070)
......................................................................


engine: Prevent move to empty quota (#845070)

https://bugzilla.redhat.com/845070

When a user was moving a disk to a domain with no defined quota (when
quota is enforced) he got an uninformative error.

The ability to move to a domain with no quota was blocked using the
validate mechanism. When quota is enforced the user must choose a domain
with a defined quota.

The massage was fixed to inform the user that the selected domain has no
assigned quota (in case a quota is available but not relevant).

Change-Id: Iab0baf6f583f06197286a976211bada4a0654cb2
Signed-off-by: Ofri Masad <omasad at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/MoveOrCopyDiskModel.java
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/SelectedQuotaValidation.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
9 files changed, 56 insertions(+), 3 deletions(-)

Approvals:
  Doron Fediuck: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/7736
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iab0baf6f583f06197286a976211bada4a0654cb2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <omasad at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-Reviewer: ofri masad <omasad at redhat.com>



More information about the Engine-commits mailing list