Change in ovirt-engine[master]: core: fix NPE in canDoAction at AttachDisk.

mkublin at redhat.com mkublin at redhat.com
Sun Sep 9 09:45:52 UTC 2012


Michael Kublin has submitted this change and it was merged.

Change subject: core: fix NPE in canDoAction at AttachDisk.
......................................................................


core: fix NPE in canDoAction at AttachDisk.

If disk is null, then the method should return instead of proceeding
further as it could lead to NPE when disk is accessed.

Change-Id: If1cb0a34c663b2b069eca92ad5229041525ba56e
Signed-off-by: Sharad Mishra <snmishra at linux.vnet.ibm.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Michael Kublin: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/7848
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If1cb0a34c663b2b069eca92ad5229041525ba56e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <snmishra at linux.vnet.ibm.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin at redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmishra at linux.vnet.ibm.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list