Change in ovirt-engine[master]: bootstrap: introduce soft timeouts for operations

yzaslavs at redhat.com yzaslavs at redhat.com
Sun Sep 9 17:50:10 UTC 2012


Yair Zaslavsky has submitted this change and it was merged.

Change subject: bootstrap: introduce soft timeouts for operations
......................................................................


bootstrap: introduce soft timeouts for operations

The only place non default ssh timeout was enforced is when getting node
id.
 AddVdsCommand::canDoAction()

So it relatively simple to add soft timeout / hard timeout support by
just modify the defaults.

Hard timeout - maximum duration of command.
Soft timeout - maximum duration since last network activity.

Reduce the default of SSHInactivityTimoutSeconds to 5 minutes, it is now
the soft timeout limit.

Add a new configuration parameter of SSHInactivityHardTimoutSeconds
which is 30 minutes.

Change-Id: Ic37e4384fda412f92bffd7a8aa809d0dfd4d8157
Signed-off-by: Alon Bar-Lev <alonbl at redhat.com>
---
M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/VdsInstallerSSH.java
M backend/manager/tools/engine-config/src/main/resources/engine-config.properties
4 files changed, 35 insertions(+), 9 deletions(-)

Approvals:
  Yair Zaslavsky: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/7734
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic37e4384fda412f92bffd7a8aa809d0dfd4d8157
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list