Change in ovirt-engine[master]: core: NPE in remove vm from Export D (#854607)

gchaplik at redhat.com gchaplik at redhat.com
Mon Sep 10 10:10:37 UTC 2012


Gilad Chaplik has submitted this change and it was merged.

Change subject: core: NPE in remove vm from Export D (#854607)
......................................................................


core: NPE in remove vm from Export D (#854607)

https://bugzilla.redhat.com/854607

when invoking remove VM/Template from export domain, we used to call
validateAndSetQuota since removeVm/TemplateFromExportDomainCommand derives from
RemoveVm/TemplateCommand. but in export case we don't use quota.
so override quota methods to do nothing in this stage.

Change-Id: I7a54bd5450a1859d892154d04300cf11d82d966d
Signed-off-by: Gilad Chaplik <gchaplik at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmFromImportExportCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateFromImportExportCommand.java
3 files changed, 29 insertions(+), 2 deletions(-)

Approvals:
  Gilad Chaplik: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/7816
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7a54bd5450a1859d892154d04300cf11d82d966d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: ofri masad <omasad at redhat.com>



More information about the Engine-commits mailing list