Change in ovirt-engine[master]: core: CommandBase: Extract getAsyncTaskManager()

mlipchuk at redhat.com mlipchuk at redhat.com
Wed Sep 12 13:29:10 UTC 2012


Maor Lipchuk has submitted this change and it was merged.

Change subject: core: CommandBase: Extract getAsyncTaskManager()
......................................................................


core: CommandBase: Extract getAsyncTaskManager()

Extracted the getAsyncTaskManager() method so it can be used instead of
AsyncTaskManager.getInstance().

This is useful for unit testing, since now the AsyncTaskManager can be
spied or mocked.

Change-Id: Ife9c2713069d14db8afa85eac6f6e3e9e7c9ae21
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
1 file changed, 9 insertions(+), 5 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, but someone else must approve
  Maor Lipchuk: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/7787
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ife9c2713069d14db8afa85eac6f6e3e9e7c9ae21
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmishra at linux.vnet.ibm.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list