Change in ovirt-engine[master]: core: VmCommand's ConcreteCreateTask

derez at redhat.com derez at redhat.com
Sun Sep 16 08:42:29 UTC 2012


Daniel Erez has submitted this change and it was merged.

Change subject: core: VmCommand's ConcreteCreateTask
......................................................................


core: VmCommand's ConcreteCreateTask

Removed ConcreteCreateTask from VmCommand,
and used the new getTaskType() mechanism introduced to CommandBase.

Note that since VmCommand is abstract, the testing was done on
RemoveVmCommand which extends it and does NOT override these methods
itself.

Change-Id: I8fb7c90caa1e327263c0b238ae0aff48ce6b2429
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/BackwardCompatibilityTaskCreationTest.java
2 files changed, 4 insertions(+), 11 deletions(-)

Approvals:
  Daniel Erez: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/7801
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8fb7c90caa1e327263c0b238ae0aff48ce6b2429
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>



More information about the Engine-commits mailing list