Change in ovirt-engine[master]: core: Fix RemoveVmTemplate regression

derez at redhat.com derez at redhat.com
Wed Sep 19 09:38:17 UTC 2012


Daniel Erez has submitted this change and it was merged.

Change subject: core: Fix RemoveVmTemplate regression
......................................................................


core: Fix RemoveVmTemplate regression

Refactoring task creation broke removing a VM template, since the
RemoveVmTemplateCommand does not propagate it's parameters to the child
commands, which causes an NPE when trying to access them. This patch
fixes this flow.

Change-Id: I27ebeee388b2975cd9a34250758a4bb954f5bd57
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllVmTemplateImageTemplatesCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateCommand.java
2 files changed, 6 insertions(+), 2 deletions(-)

Approvals:
  Daniel Erez: Looks good to me, approved
  Allon Mureinik: Verified


--
To view, visit http://gerrit.ovirt.org/8049
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I27ebeee388b2975cd9a34250758a4bb954f5bd57
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>



More information about the Engine-commits mailing list