Change in ovirt-engine[master]: webadmin: SearchSuggestionDisplay Findbugs

derez at redhat.com derez at redhat.com
Thu Sep 27 11:40:53 UTC 2012


Daniel Erez has submitted this change and it was merged.

Change subject: webadmin: SearchSuggestionDisplay Findbugs
......................................................................


webadmin: SearchSuggestionDisplay Findbugs

Fixed the FindBugs issue:
"Possible null pointer dereference of suggestBox in
org.ovirt.engine.ui.webadmin.widget.autocomplete.
SearchSuggestionDisplay.showSuggestions
(SuggestBox,Collection, boolean, boolean,
SuggestBox$SuggestionCallback)"

The addition of the autoHidePartner should be done inside the
null-check, not after it.

Change-Id: Iffde64f273f4a9bdfa2e61a280827f5b8f0e377b
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/autocomplete/SearchSuggestionDisplay.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Daniel Erez: Verified; Looks good to me, approved
  Allon Mureinik: Verified; Looks good to me, but someone else must approve


--
To view, visit http://gerrit.ovirt.org/8196
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iffde64f273f4a9bdfa2e61a280827f5b8f0e377b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak at redhat.com>



More information about the Engine-commits mailing list