Change in ovirt-engine[master]: packaging: removed --no-mem-check from engine-setup

juan.hernandez at redhat.com juan.hernandez at redhat.com
Mon Apr 1 09:44:05 UTC 2013


Juan Hernandez has submitted this change and it was merged.

Change subject: packaging: removed --no-mem-check from engine-setup
......................................................................


packaging: removed --no-mem-check from engine-setup

If minimum memory requirements are not met:
- on interactive mode, stop, warn and ask if to abort
- on answer file mode don't stop, issue the warning in the log.
The assumption here is that users of the answer file are aware
of the requirements and had to read the manual to use this option.

Moved requirements check after process initialization
avoiding double execution of the check.

Change-Id: I7180589490cf74fcb402bd3b957ae8ae8479715d
Bug-Url: https://bugzilla.redhat.com/928386
Signed-off-by: Sandro Bonazzola <sbonazzo at redhat.com>
---
M packaging/fedora/setup/engine-setup.py
1 file changed, 23 insertions(+), 11 deletions(-)

Approvals:
  Juan Hernandez: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/13409
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7180589490cf74fcb402bd3b957ae8ae8479715d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgoldboi at redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>



More information about the Engine-commits mailing list