Change in ovirt-engine[master]: core: Fix unpermitted storage related commands in Audit mode

gchaplik at redhat.com gchaplik at redhat.com
Tue Apr 2 08:13:47 UTC 2013


Gilad Chaplik has submitted this change and it was merged.

Change subject: core: Fix unpermitted storage related commands in Audit mode
......................................................................


core: Fix unpermitted storage related commands in Audit mode

When Data Center is in quota enforcement mode 'Audit', a user can perform
disk actions on a SD which he does not have permission for (e.g. move
disk).

This was caused by wrong permission subjects list creation which
neglected the 'Audit' mode.

Fixed the permission subjects list creation to include 'Audit' mode as
well as 'Disabled' mode (in 'Enforcing' mode this operation will be
blocked by the quota QuotaManager)

Change-Id: Ie50e7dd91611c2b959cea3a78c2684451836760b
Signed-off-by: Ofri Masad <omasad at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Gilad Chaplik: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/13410
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie50e7dd91611c2b959cea3a78c2684451836760b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <omasad at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: ofri masad <omasad at redhat.com>



More information about the Engine-commits mailing list