Change in ovirt-engine[master]: engine: Additional clean up in AuditLogDirector

mkublin at redhat.com mkublin at redhat.com
Tue Apr 2 08:34:26 UTC 2013


Michael Kublin has submitted this change and it was merged.

Change subject: engine: Additional clean up in AuditLogDirector
......................................................................


engine: Additional clean up in AuditLogDirector

Variable auditLogable can not be null, if it null we will fail on
NullPointerException inside updateTimeoutLogableObject method.
After removing such condition, were removed all relevant and dead code.
Also, I chnaged tempVar to auditLog varibale, don't see reason for using tempVar

Change-Id: Ia0eb406d78965bb0d84c7ce80761028877ab2879
Signed-off-by: Michael Kublin <mkublin at redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java
1 file changed, 38 insertions(+), 48 deletions(-)

Approvals:
  Michael Kublin: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/13426
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia0eb406d78965bb0d84c7ce80761028877ab2879
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkublin at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list