Change in ovirt-engine[master]: core: AddVmFromSnapshot - avoid early end method run

amureini at redhat.com amureini at redhat.com
Sun Apr 7 06:53:47 UTC 2013


Allon Mureinik has submitted this change and it was merged.

Change subject: core: AddVmFromSnapshot - avoid early end method run
......................................................................


core: AddVmFromSnapshot - avoid early end method run

When adding vm as a clone of snapshot, the vm id should be set as
the entity id for the child commands parameters - this prevent a
situation in which the end method is called too early.

NOTE: seems like the MoveOrCopyImageGroupParameters class might be
re-factored so that in a case of given ContainerId, it will be set as the
entity id - but that's not in the scope of this change.

Change-Id: I7a536cb3c530fd9caa0b121830481604c0558d53
Signed-off-by: Liron Aravot <laravot at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/12267
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7a536cb3c530fd9caa0b121830481604c0558d53
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Daniel Paikov <paikov at gmail.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>



More information about the Engine-commits mailing list