Change in ovirt-engine[master]: restapi: Use DbUser.isGroup() properly

amureini at redhat.com amureini at redhat.com
Sun Apr 7 12:47:06 UTC 2013


Allon Mureinik has submitted this change and it was merged.

Change subject: restapi: Use DbUser.isGroup() properly
......................................................................


restapi: Use DbUser.isGroup() properly

Replaced an explicit string check on DbUser's user name with the BE's
method isGroup().

This achieves two goals:
1. It's easier to understand.
2. It removes a dependency on the deprecated StringHelper.

Change-Id: Ib17d50003d2b1425db9a2fc17c206da2d4db5de7
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedPermissionsResource.java
1 file changed, 5 insertions(+), 8 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/13653
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib17d50003d2b1425db9a2fc17c206da2d4db5de7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern at redhat.com>
Gerrit-Reviewer: Ori Liel <oliel at redhat.com>



More information about the Engine-commits mailing list