Change in ovirt-engine[master]: packaging: engine-service: do not clean environment

juan.hernandez at redhat.com juan.hernandez at redhat.com
Mon Apr 8 06:39:58 UTC 2013


Juan Hernandez has submitted this change and it was merged.

Change subject: packaging: engine-service: do not clean environment
......................................................................


packaging: engine-service: do not clean environment

the init system may put important variables in environment.

add LC_ALL as java is effected by AC_CTYPE per defaults of string
conversions, as if it is set by init it will effect us.

in practice we should only set LC_CTYPE or use jnu.encoding, when
we are sure that no default locale is used for conversions within
application.

Change-Id: Ia8231b343574df83e65c55d9ffa75698a3f2d692
Signed-off-by: Alon Bar-Lev <alonbl at redhat.com>
---
M packaging/fedora/engine-service.py.in
1 file changed, 5 insertions(+), 3 deletions(-)

Approvals:
  Juan Hernandez: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/13643
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia8231b343574df83e65c55d9ffa75698a3f2d692
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>



More information about the Engine-commits mailing list