Change in ovirt-engine[master]: core : AddVmFromSnapshot - use device information from snaps...

amureini at redhat.com amureini at redhat.com
Mon Apr 8 13:29:18 UTC 2013


Allon Mureinik has submitted this change and it was merged.

Change subject: core : AddVmFromSnapshot - use device information from snapshot.
......................................................................


core : AddVmFromSnapshot - use device information from snapshot.

When adding a vm from snapshot (clone of a snapshot), the device
information was taken from the vm current state and not from the
snapshot configuration - which caused the cloned vm to not be in the
desired state and possibly have missing devices.

Change-Id: I0611bbbef00fd2c2390ead5f3110e56dcaacd579
BUg-Url: https://bugzilla.redhat.com/show_bug.cgi?id=882644
Signed-off-by: Liron Aravot <laravot at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
2 files changed, 25 insertions(+), 20 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/12452
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0611bbbef00fd2c2390ead5f3110e56dcaacd579
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Daniel Paikov <paikov at gmail.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list