Change in ovirt-engine[master]: core: Remove LdapSeachGroupsByQuery.initFromDb

amureini at redhat.com amureini at redhat.com
Mon Apr 8 14:28:45 UTC 2013


Allon Mureinik has submitted this change and it was merged.

Change subject: core: Remove LdapSeachGroupsByQuery.initFromDb
......................................................................


core: Remove LdapSeachGroupsByQuery.initFromDb

Removed LdapSeachGroupByQueryCommand.initFromDb, since all it did was
query an LdapGroup and save it into a local variable that was never used
again.

Note that this patch solves a DLS_DEAD_LOCAL_STORE FindBugs warning on
this class.

Change-Id: I581fab9aa581a3a5093f98cc48edeaffc9080c44
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapSearchGroupsByQueryCommand.java
1 file changed, 0 insertions(+), 6 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/13649
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I581fab9aa581a3a5093f98cc48edeaffc9080c44
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list