Change in ovirt-engine[master]: packaging: engine-service: clean /var/tmp in upgrade and cle...

juan.hernandez at redhat.com juan.hernandez at redhat.com
Tue Apr 9 07:00:59 UTC 2013


Juan Hernandez has submitted this change and it was merged.

Change subject: packaging: engine-service: clean /var/tmp in upgrade and cleanup
......................................................................


packaging: engine-service: clean /var/tmp in upgrade and cleanup

previous service implementation used mixed ownership of root/ovirt in
/var/tmp/ovirt-engine, /var/lib/ovirt-engine/deployments.

the /var/tmp/ovirt-engine was not cleared if daemon exited so likely to
remain.

new service implementation does not run under root account, so having
root owned resources is not healthy.

during upgrade setup correct setting, during setup remove leftovers, as
engine-cleanup not to be trusted as it does not actually revert to
initial state.

Change-Id: If0efa0b8a71673140490e2c363af7d3ba6044ffe
Signed-off-by: Alon Bar-Lev <alonbl at redhat.com>
---
M packaging/fedora/setup/basedefs.py
M packaging/fedora/setup/engine-setup.py
M packaging/fedora/setup/engine-upgrade.py
M packaging/fedora/setup/output_messages.py
4 files changed, 27 insertions(+), 3 deletions(-)

Approvals:
  Juan Hernandez: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/13663
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If0efa0b8a71673140490e2c363af7d3ba6044ffe
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>



More information about the Engine-commits mailing list