Change in ovirt-engine[master]: core: fix overriding placeholder val in audit log

mkublin at redhat.com mkublin at redhat.com
Tue Apr 9 13:29:24 UTC 2013


Michael Kublin has submitted this change and it was merged.

Change subject: core: fix overriding placeholder val in audit log
......................................................................


core: fix overriding placeholder val in audit log

Fix overriding placeholder value set in AugitLogableBase.customValues
with empty string in TypeCompat.
In cases when the value of a placeholder was already populated with
custom value,
no need to invoke a method to try populate it again since in some cases
an empty string returns causing the override of already set non empty value.

Example where bug is shown - storagePoolName is displayed as unknown.
"Host cannot access one of the Storage Domains attached to the Data
Center <UNKNOWN>. Setting Host state to Non-Operational."

Change-Id: I4239085d0bd0246369e93e38a394ab8306c05887
Signed-off-by: Alissa Bonas <abonas at redhat.com>
---
M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/TypeCompat.java
1 file changed, 9 insertions(+), 7 deletions(-)

Approvals:
  Michael Kublin: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/13691
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4239085d0bd0246369e93e38a394ab8306c05887
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abonas at redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin at redhat.com>



More information about the Engine-commits mailing list