Change in ovirt-engine[master]: core: Remove GetEventNotificationMethods

lhornyak at redhat.com lhornyak at redhat.com
Fri Apr 12 08:27:10 UTC 2013


Laszlo Hornyak has submitted this change and it was merged.

Change subject: core: Remove GetEventNotificationMethods
......................................................................


core: Remove GetEventNotificationMethods

GetEventNotificationMethodsQuery is not used anywhere in
the code, and hence should be removed.

This patch removes the following:
1. The GetEventNotificationMethodsQuery class.
2. The GetEventNotificationMethods constant representing
   it in VdcQueryType.
3. The getAllEventNotificationMethods() method in EvetDAO, its
   implementation, test and underlying stored procedure, as this
   method was only used by the aforementioned query.

Signed-off-by: Allon Mureinik <amureini at redhat.com>
Change-Id: I9ab37e8fb5a1602b0d8d0d9b1107c596dd33093b
---
M backend/manager/dbscripts/event_sp.sql
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetEventNotificationMethodsQuery.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/EventDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/EventDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/EventDAOTest.java
6 files changed, 5 insertions(+), 63 deletions(-)

Approvals:
  Laszlo Hornyak: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/13601
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9ab37e8fb5a1602b0d8d0d9b1107c596dd33093b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list