Change in ovirt-engine[master]: core: Remove GetAgentFenceOptions2Query

amureini at redhat.com amureini at redhat.com
Mon Apr 15 22:18:05 UTC 2013


Allon Mureinik has submitted this change and it was merged.

Change subject: core: Remove GetAgentFenceOptions2Query
......................................................................


core: Remove GetAgentFenceOptions2Query

GetAgentFenceOptionsQuery and GetAgentFenceOptions2Query are completely
identical except for the usage of different APIs of VdsFenceOptions.

Since GetAgentFenceOptions is not used anywhere, it is removed, and
GetAgentFenceOptions2 loses it "2" and get a name the better suits
conventions (not to mention common sense).

This patch includes:
1. Removing the old GetAgentFenceOptionsQuery class and renaming
   GetAgentFenceOptions2Query to take its place.
2. Removing the old GetAgentFenceOptions constant in the VdsQueryTye
   enum, and renaming GetAgentFenceOptions2 to take its place.
3. Clearing up the VdsFenceOptions class from methods with "2" in their
   name - either by removing unused methods, or by renaming them to a
   more sensible name.

Change-Id: Id2d7f15c16257f39f162b52d22f7c2faf8eb291a
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAgentFenceOptions2Query.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAgentFenceOptionsQuery.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/queries/VdcQueryTypeTest.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/pm/VdsFenceOptions.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
6 files changed, 8 insertions(+), 44 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/13606
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id2d7f15c16257f39f162b52d22f7c2faf8eb291a
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak at redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list