Change in ovirt-engine[master]: core: Fix backend allow 'cpu pinning' with no host

lhornyak at redhat.com lhornyak at redhat.com
Wed Apr 17 13:23:23 UTC 2013


Laszlo Hornyak has submitted this change and it was merged.

Change subject: core: Fix backend allow 'cpu pinning' with no host
......................................................................


core: Fix backend allow 'cpu pinning' with no host

When working via API the user could add a VM with no defined host (start
from any host in cluster) and set the 'cpu pinning' string. This should
not be permitted.

Fixed the validity checked in the AddVmCommand and UpdateVmCommand.
Added a new error message.

Change-Id: Iff00debc039a5476c19966dd91425566a3562e02
Bug-Url: https://bugzilla.redhat.com/928689
Signed-off-by: Ofri Masad <omasad at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmManagementCommandBase.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
5 files changed, 6 insertions(+), 0 deletions(-)

Approvals:
  Laszlo Hornyak: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/13971
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iff00debc039a5476c19966dd91425566a3562e02
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <omasad at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak at redhat.com>
Gerrit-Reviewer: ofri masad <omasad at redhat.com>



More information about the Engine-commits mailing list