Change in ovirt-engine[master]: core: Remove PerformImagesChecks from AddDisk

amureini at redhat.com amureini at redhat.com
Fri Apr 19 17:46:58 UTC 2013


Allon Mureinik has submitted this change and it was merged.

Change subject: core: Remove PerformImagesChecks from AddDisk
......................................................................


core: Remove PerformImagesChecks from AddDisk

Several previous patches have removed checks not related to DiskImages
from PerformImagesChecks (The last one being change id
I4cfc895dceed4de520476ed5e3fa9c1c7cfd78f4, that removed storage domain
validation).

Now, since PerformImagesChecks only checks DiskImages, passing an
emptyList() to it is meaningless, and can safely be removed.

Change-Id: I457dee7645dd16c430eda6886e03df77c7e91383
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddDiskToVmCommandTest.java
2 files changed, 0 insertions(+), 13 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/12641
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I457dee7645dd16c430eda6886e03df77c7e91383
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>



More information about the Engine-commits mailing list