Change in ovirt-engine[master]: findbugs: When implementing compareTo implement Object.equal...

shavivi at redhat.com shavivi at redhat.com
Sun Apr 21 13:47:21 UTC 2013


Shahar Havivi has submitted this change and it was merged.

Change subject: findbugs: When implementing compareTo implement Object.equals as well
......................................................................


findbugs: When implementing compareTo implement Object.equals as well

Change-Id: I69d3ee3cded96c33c4e833fdca09461b7825cf07
Signed-off-by: Shahar Havivi <shavivi at redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/NetworkStatistics.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VmNetworkStatistics.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/dns/DnsSRVLocator.java
3 files changed, 117 insertions(+), 0 deletions(-)

Approvals:
  Shahar Havivi: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/14039
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I69d3ee3cded96c33c4e833fdca09461b7825cf07
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list