Change in ovirt-engine[master]: frontend: reduce duplicate code related to run-once capabili...

alkaplan at redhat.com alkaplan at redhat.com
Mon Apr 22 12:10:52 UTC 2013


Alona Kaplan has submitted this change and it was merged.

Change subject: frontend: reduce duplicate code related to run-once capability
......................................................................


frontend: reduce duplicate code related to run-once capability

Changed RunOnceModel to be abstract and add UserPortalRunOnceModel that
extends it. the code that initialize the run-once-model in the user
portal was moved from UserPortalListModel to it.

Add WebadminRunOnceModel that extends RunOnceModel for the web-admin.
the code that initializes the run-once-model in the web-admin was moved
from VmListModel to it.

Remove duplicate code in the run-once model of the webadmin and
the run-once model of the user-portal, and put the common code in
RunOnceModel instead.

Change-Id: I6561df71f093e2739e689722ead4f85428c04d06
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RunOnceModel.java
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UserPortalRunOnceModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/WebadminRunOnceModel.java
5 files changed, 387 insertions(+), 587 deletions(-)

Approvals:
  Alona Kaplan: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/13207
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6561df71f093e2739e689722ead4f85428c04d06
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>



More information about the Engine-commits mailing list